Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport missing showRegisterLinks initializations to Palm #566

Conversation

yusuf-musleh
Copy link

Description

Backport of openedx#32783, includes missing initializations in JS files that were causing JS tests to fail.

(cherry picked from commit 3025ab5) (cherry picked from commit 2ee57b7d59ed53fa928f9b19127038b4cf0b4620)

Supporting information

Private-ref: BB-7694

Testing instructions

  1. Set the SHOW_REGISTRATION_LINKS flag to False in both lms and cms
  2. Check LMS: http://localhost:18000/ has no register button at the top
  3. Check LMS: http://localhost:18000/register still works does work
  4. Check LMS: http://localhost:18000/login doesn't show links to the registration form
  5. Check CMS (studio): http://localhost:18010/ doesn't show links to register an account

(cherry picked from commit 3025ab5)
(cherry picked from commit 2ee57b7d59ed53fa928f9b19127038b4cf0b4620)
@viadanna
Copy link
Member

viadanna commented Aug 3, 2023

Approved based on openedx#32783

@yusuf-musleh yusuf-musleh merged commit 65112de into opencraft-release/palm.1 Aug 4, 2023
40 checks passed
@yusuf-musleh yusuf-musleh deleted the yusuf-musleh/palm-backport-registration-form-feature-toggle-inits branch August 4, 2023 14:49
navinkarkera pushed a commit that referenced this pull request Sep 4, 2024
reverts changes from #566

Commit generated by workflow `openedx/edx-platform/.github/workflows/upgrade-one-python-dependency.yml@refs/heads/master`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants